Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks on audio attachments + message box icons #20804

Merged
merged 15 commits into from Nov 7, 2019

Conversation

@cecileboucheron
Copy link
Contributor

cecileboucheron commented Nov 6, 2019

cc @mmaxim

@cecileboucheron cecileboucheron changed the title Tweaks on audio attachments Tweaks on audio attachments + message box icons Nov 6, 2019
@cecileboucheron cecileboucheron requested a review from mmaxim Nov 6, 2019
@@ -314,7 +314,7 @@ const AudioButton = (props: ButtonProps) => {
style={{
position: 'absolute',
right: 48,
top: 1,
top: -1,

This comment has been minimized.

Copy link
@cecileboucheron

cecileboucheron Nov 6, 2019

Author Contributor

@mmaxim This recenters the icon inside the blue circle, but since I shrinked all the sizes of the message box icons, it's no longer aligned with the grey mic icon (we can see it on release). Do you know where to tweak the position of the whole mic + circles thing?

This comment has been minimized.

Copy link
@mmaxim

mmaxim Nov 6, 2019

Contributor

All this stuff is absolute positioned, so if the sizes of this stuff changes you need to track down all the stuff that is off. I can do it tomorrow on this branch. Also I merged a change to the lock that conflicts with this (lock moves when you swipe up)

cecileboucheron and others added 5 commits Nov 6, 2019
@mmaxim
mmaxim approved these changes Nov 7, 2019
@mmaxim mmaxim merged commit 61ef7b3 into master Nov 7, 2019
0 of 2 checks passed
0 of 2 checks passed
ci/circleci CircleCI is running your tests
Details
continuous-integration/jenkins/pr-head This commit is being built
Details
@mmaxim mmaxim deleted the cecile/DESKTOP-tweaks-on-audio-attachments branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.