Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some random perf stuff #20806

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@mmaxim
Copy link
Contributor

mmaxim commented Nov 6, 2019

  • Use more threads on mobile
  • Restore cancelable nature of unbox requests from UI.
@mmaxim mmaxim requested a review from joshblum Nov 6, 2019
Copy link
Member

joshblum left a comment

any noticeable gains or just a hunch?

@mmaxim

This comment has been minimized.

Copy link
Contributor Author

mmaxim commented Nov 6, 2019

The cancelable thing blocks the thread from showing cached data frequently.

@mmaxim mmaxim merged commit f1dfa58 into master Nov 6, 2019
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@mmaxim mmaxim deleted the mike/exp4 branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.