Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cap inbox small team size, and add a button to increase it #21844

Merged
merged 8 commits into from Dec 30, 2019

Conversation

mmaxim
Copy link
Contributor

@mmaxim mmaxim commented Dec 29, 2019

Add a paging like interface for the inbox in the UI. The goal of this PR is to improve the performance of the frontend. Subtracting out a large amount of useless data that is transmitted in, and likely iterated over in many places should be a noticeable performance win for people with large inboxes.

The main change here is to only load in a fixed number of small teams convs when loading the inbox. If the user scrolls down, they are presented with a "Load more" button which will grab more convs. When the small teams are collapsed, the inbox bound resets back to the default. Therefore, we degrade to current status quo if the user charges all the way down their inbox, but are faster at all points in between (and if they close the small teams).

cc @malgorithms @cecileboucheron @adamjspooner

@mmaxim mmaxim requested a review from a team December 29, 2019 19:37
@mmaxim mmaxim marked this pull request as ready for review December 29, 2019 19:37
@mmaxim mmaxim merged commit 01897e2 into master Dec 30, 2019
@mmaxim mmaxim deleted the mike/HOTPOT-1581 branch December 30, 2019 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants