Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install unrestricted bots #21880

Merged
merged 6 commits into from Jan 2, 2020
Merged

install unrestricted bots #21880

merged 6 commits into from Jan 2, 2020

Conversation

@mmaxim
Copy link
Contributor

mmaxim commented Jan 2, 2020

Also clean up how we figure out the role of a bot in a conversation.

mmaxim added 5 commits Jan 2, 2020
wip
wip
wip
tsc
@mmaxim mmaxim requested review from joshblum and keybase/react-hackers Jan 2, 2020
@@ -953,6 +953,24 @@ func MemberRole(ctx context.Context, g *libkb.GlobalContext, teamname, username
return role, err
}

func MemberRoleFromID(ctx context.Context, g *libkb.GlobalContext, teamID keybase1.TeamID, username string) (role keybase1.TeamRole, err error) {
uv, err := loadUserVersionByUsername(ctx, g, username, false /* useTracking */)

This comment has been minimized.

Copy link
@joshblum

joshblum Jan 2, 2020

Member

could make a teamGetter like in remove below to reduce code duplication

@mmaxim mmaxim merged commit c322104 into master Jan 2, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci Your tests passed on CircleCI!
Details
@mmaxim mmaxim deleted the mike/HOTPOT-1585 branch Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.