Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for a blank TLFID and give special error #21883

Merged
merged 3 commits into from Jan 3, 2020
Merged

check for a blank TLFID and give special error #21883

merged 3 commits into from Jan 3, 2020

Conversation

@mmaxim
Copy link
Contributor

mmaxim commented Jan 2, 2020

No description provided.

@mmaxim mmaxim requested a review from joshblum Jan 2, 2020
// if the server message doesn't have a TLFID, then it isn't available to us. This is most commonly
// used when restricted bots try to read messages not encrypted for them.
if boxed.ClientHeader.Conv.Tlfid.IsNil() {
return b.makeErrorMessage(ctx, boxed, errBoxerUnavailableMessage), nil

This comment has been minimized.

Copy link
@joshblum

joshblum Jan 2, 2020

Member

will ServerHeader be nil in this case? makeErrorMessage assumes it isn't

This comment has been minimized.

Copy link
@mmaxim

mmaxim Jan 2, 2020

Author Contributor

No, I can't do it like that, see keybase/keybase#4964

mmaxim added 2 commits Jan 3, 2020
@mmaxim mmaxim merged commit 849c2a4 into master Jan 3, 2020
1 check was pending
1 check was pending
ci/circleci CircleCI is running your tests
Details
@mmaxim mmaxim deleted the mike/HOTPOT-1565 branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.