Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide manage bot functionality for non-admins #21886

Merged
merged 8 commits into from Jan 3, 2020
Merged

hide manage bot functionality for non-admins #21886

merged 8 commits into from Jan 3, 2020

Conversation

@mmaxim
Copy link
Contributor

mmaxim commented Jan 3, 2020

No description provided.

mmaxim added 2 commits Jan 3, 2020
@mmaxim mmaxim requested a review from keybase/react-hackers Jan 3, 2020
@hyperobject hyperobject self-requested a review Jan 3, 2020
Copy link
Contributor

hyperobject left a comment

Would probably be good to hide the 'uninstall' button in teams/team/rows/bot-row/bot-menu.tsx if you're not an admin, and also maybe change the "edit settings" button there to "view settings"

mmaxim added 2 commits Jan 3, 2020
@mmaxim mmaxim requested a review from hyperobject Jan 3, 2020
Copy link
Contributor

hyperobject left a comment

lgtm!

mmaxim added 4 commits Jan 3, 2020
fix
tsc
@mmaxim mmaxim merged commit 60b5f5d into master Jan 3, 2020
1 check was pending
1 check was pending
ci/circleci CircleCI is running your tests
Details
@mmaxim mmaxim deleted the mike/HOTPOT-1595 branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.