Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Stop to push handler #21929

Merged
merged 1 commit into from Jan 7, 2020
Merged

add Stop to push handler #21929

merged 1 commit into from Jan 7, 2020

Conversation

@joshblum
Copy link
Member

joshblum commented Jan 7, 2020

Was causing test runs to fail with a logging panic after the tests completed, made it difficult to debug a legitimate race.

$ go test -run TestChatSrvGap -count 20
PASS
ok      github.com/keybase/client/go/chat       167.028s

cc @AMarcedone

@joshblum joshblum requested a review from mmaxim Jan 7, 2020
@mmaxim
mmaxim approved these changes Jan 7, 2020
@joshblum joshblum merged commit ac4abc2 into master Jan 7, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci Your tests passed on CircleCI!
Details
@joshblum joshblum deleted the joshblum/push-Y2K-1199 branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.