Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explode expired messages on FetchMessages #21942

Merged
merged 2 commits into from Jan 8, 2020
Merged

Conversation

@joshblum
Copy link
Member

joshblum commented Jan 8, 2020

The search indexer fetches messages through the GetMessages API, I think this could cause an already exploded message to erroneously appear in search results since we didn't check the message expiration when reading from storage here.

@joshblum joshblum requested a review from mmaxim Jan 8, 2020
@mmaxim
mmaxim approved these changes Jan 8, 2020
@joshblum joshblum force-pushed the joshblum/ex-HOTPOT-1610 branch from ed32ced to 9963820 Jan 8, 2020
@joshblum joshblum merged commit 291d508 into master Jan 8, 2020
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@joshblum joshblum deleted the joshblum/ex-HOTPOT-1610 branch Jan 8, 2020
mmaxim added a commit that referenced this pull request Jan 8, 2020
joshblum added a commit that referenced this pull request Jan 8, 2020
joshblum added a commit that referenced this pull request Jan 9, 2020
joshblum added a commit that referenced this pull request Jan 9, 2020
joshblum added a commit that referenced this pull request Jan 9, 2020
* Unrevert "explode expired messages on FetchMessages (#21942)"

This reverts commit 1d7ab2c.

* check if assetDelete is nil

* map instead
jakob223 added a commit that referenced this pull request Jan 14, 2020
* explode expired messages on FetchMessages

* fix test
jakob223 added a commit that referenced this pull request Jan 14, 2020
jakob223 added a commit that referenced this pull request Jan 14, 2020
* Unrevert "explode expired messages on FetchMessages (#21942)"

This reverts commit 1d7ab2c.

* check if assetDelete is nil

* map instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.