Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add logic for authorIsBot in adhoc teams #21951

Merged
merged 1 commit into from Jan 9, 2020

Conversation

@hyperobject
Copy link
Contributor

hyperobject commented Jan 8, 2020

Previously, authorIsBot checks would always return false in adhoc teams because teamname was not defined, which caused the bot icon to display incorrectly. This PR adds logic for adhoc teams to check if the author is a bot or not.

@hyperobject hyperobject requested a review from keybase/react-hackers Jan 8, 2020
@mmaxim
mmaxim approved these changes Jan 9, 2020
@hyperobject hyperobject merged commit d9ea756 into master Jan 9, 2020
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@hyperobject hyperobject deleted the cori/fix/impteam-bot-icons branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.