Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrevert "explode expired messages on FetchMessages (#21942) #21958

Merged
merged 3 commits into from Jan 9, 2020

Conversation

@joshblum
Copy link
Member

joshblum commented Jan 8, 2020

No description provided.

@joshblum joshblum requested a review from mmaxim Jan 8, 2020
@joshblum joshblum changed the title Joshblum/unrevert Unrevert "explode expired messages on FetchMessages (#21942) Jan 8, 2020
go/chat/storage/storage.go Outdated Show resolved Hide resolved
@joshblum joshblum force-pushed the joshblum/unrevert branch from 13f3466 to 6b0dbf2 Jan 9, 2020
@joshblum joshblum requested a review from mmaxim Jan 9, 2020
@joshblum joshblum force-pushed the joshblum/unrevert branch from 6b0dbf2 to 2a4b8c7 Jan 9, 2020
@mmaxim
mmaxim approved these changes Jan 9, 2020
@joshblum joshblum merged commit 5629464 into master Jan 9, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci Your tests passed on CircleCI!
Details
@joshblum joshblum deleted the joshblum/unrevert branch Jan 9, 2020
jakob223 added a commit that referenced this pull request Jan 14, 2020
* Unrevert "explode expired messages on FetchMessages (#21942)"

This reverts commit 1d7ab2c.

* check if assetDelete is nil

* map instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.