Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto in GUI: Design Changes Pass 2 #21979

Merged
merged 28 commits into from Jan 14, 2020
Merged

Conversation

@thebearjew
Copy link
Contributor

thebearjew commented Jan 10, 2020


  • Auto focus inputs on tab change
  • Left align output bar buttons
  • Add gap between buttons
  • Set button sizes to be Default
@thebearjew thebearjew requested a review from keybase/react-hackers Jan 10, 2020
@thebearjew

This comment has been minimized.

Copy link
Contributor Author

thebearjew commented Jan 10, 2020

@thebearjew thebearjew force-pushed the thebearjew/crypto-design-tweaks-pass-2 branch from 4bb4b14 to 0506218 Jan 10, 2020
@cecileboucheron

This comment has been minimized.

Copy link
Contributor

cecileboucheron commented Jan 10, 2020

Lgtm! Added these tweaks:
• Removed placeholder code
• Removed extra dividers
• Always keep "To:"

@cecileboucheron

This comment has been minimized.

Copy link
Contributor

cecileboucheron commented Jan 10, 2020

• New nav icon

@thebearjew thebearjew mentioned this pull request Jan 13, 2020
1 of 2 tasks complete
thebearjew and others added 24 commits Jan 9, 2020
Also hides phone and email as team buildling services
cecileboucheron and others added 2 commits Jan 13, 2020
@thebearjew thebearjew force-pushed the thebearjew/crypto-design-tweaks-pass-2 branch from 71b01fe to cc47fdd Jan 13, 2020
@mmaxim
mmaxim approved these changes Jan 14, 2020
Copy link
Contributor

mmaxim left a comment

🚢 this since it seems to be blocking the integration PR

thebearjew and others added 2 commits Jan 14, 2020
* Enable saltpack RPC calls

* WIP

* Respect plaintext newlines

* WIP

* All RPCs connected

* Cleanup comments

* Change encrypt options re-runs saltpackEncrypt

* Remove logging

* Reinstate file rpcs as disabled

* crypto: file ops, hiddenstring, hook up verification (#22025)

* File RPCs working, no hiddenstrings, not using signed verification

* Add drag and drop titles

* Hook up signature verification

* crypto: move string and file ops to take HiddenString

* use signed flag for decrypt

* lint

Co-authored-by: Chris Ball <chris-github@printf.net>
@thebearjew thebearjew merged commit 7365134 into master Jan 14, 2020
1 check was pending
1 check was pending
ci/circleci CircleCI is running your tests
Details
@thebearjew thebearjew deleted the thebearjew/crypto-design-tweaks-pass-2 branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.