Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce cache lifetime to 1hr #22002

Closed
wants to merge 1 commit into from
Closed

reduce cache lifetime to 1hr #22002

wants to merge 1 commit into from

Conversation

@joshblum
Copy link
Member

joshblum commented Jan 12, 2020

No description provided.

@joshblum joshblum requested a review from mmaxim Jan 12, 2020
@mmaxim
mmaxim approved these changes Jan 13, 2020
@mmaxim

This comment has been minimized.

Copy link
Contributor

mmaxim commented Jan 13, 2020

I'm not sure about this though, might be too often. Should have some kind of hash associated with being up to date I think.

@joshblum

This comment has been minimized.

Copy link
Member Author

joshblum commented Jan 13, 2020

@joshblum

This comment has been minimized.

Copy link
Member Author

joshblum commented Jan 13, 2020

Actually we refresh in the background on each request so having a stale entry initially should be ok

@joshblum joshblum closed this Jan 13, 2020
@joshblum joshblum deleted the joshblum/time branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.