Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bot to channel button #22008

Merged
merged 5 commits into from Jan 13, 2020
Merged

Add bot to channel button #22008

merged 5 commits into from Jan 13, 2020

Conversation

@hyperobject
Copy link
Contributor

hyperobject commented Jan 13, 2020

This PR adds an "add to this channel" button on bot rows in the info panel to allow users to add bots to channels. This icon shows up if

  • you are in a big team
  • the bot is currently installed in that team
  • the bot is not in the channel you're viewing

todo:

  • design feedback
hyperobject added 2 commits Jan 10, 2020
@hyperobject hyperobject requested a review from keybase/react-hackers Jan 13, 2020
@hyperobject hyperobject changed the title Cori/hotpot 1650/bot add to channel Add bot to channel button Jan 13, 2020
@mmaxim
mmaxim approved these changes Jan 13, 2020
hyperobject added 2 commits Jan 13, 2020
@hyperobject hyperobject requested a review from mmaxim Jan 13, 2020
@hyperobject

This comment has been minimized.

Copy link
Contributor Author

hyperobject commented Jan 13, 2020

@mmaxim re-requesting review bc i did some weird stuff with types i'd like to get another set of eyes on

@mmaxim
mmaxim approved these changes Jan 13, 2020
@mmaxim

This comment has been minimized.

Copy link
Contributor

mmaxim commented Jan 13, 2020

🚢

@hyperobject hyperobject merged commit 6e099f2 into master Jan 13, 2020
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@hyperobject hyperobject deleted the cori/HOTPOT-1650/bot-add-to-channel branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.