Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bot to channel button improvements #22022

Merged
merged 1 commit into from Jan 13, 2020
Merged

Conversation

@hyperobject
Copy link
Contributor

hyperobject commented Jan 13, 2020

Fixes a couple issues and improves functionality of the add bot to channel button by stopping the onclick action bubbling to the bot row component, and adds individual spinners to the buttons with the new addUserToChannel action and waiting key.

allows add bot buttons to have individual spinners
@hyperobject hyperobject requested a review from keybase/react-hackers Jan 13, 2020
@mmaxim
mmaxim approved these changes Jan 13, 2020
@hyperobject hyperobject merged commit 398aaab into master Jan 13, 2020
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@hyperobject hyperobject deleted the cori/fix/add-to-channel-modal branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.