Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort badged convs first in widget #22031

Merged
merged 1 commit into from Jan 15, 2020
Merged

sort badged convs first in widget #22031

merged 1 commit into from Jan 15, 2020

Conversation

@mmaxim
Copy link
Contributor

mmaxim commented Jan 14, 2020

@mmaxim mmaxim requested a review from joshblum Jan 14, 2020
Copy link
Member

joshblum left a comment

lgtm but can you rebase on #21975 to use chat1.ConvIDStr?

@mmaxim

This comment has been minimized.

Copy link
Contributor Author

mmaxim commented Jan 14, 2020

I'll wait for that to be merged

@mmaxim

This comment has been minimized.

Copy link
Contributor Author

mmaxim commented Jan 15, 2020

I'm going to merge this

@mmaxim mmaxim merged commit f4dcaf4 into master Jan 15, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci Your tests passed on CircleCI!
Details
@mmaxim mmaxim deleted the mike/HOTPOT-1641 branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.