Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new channel system message #22338

Merged
merged 11 commits into from Feb 4, 2020
Merged

new channel system message #22338

merged 11 commits into from Feb 4, 2020

Conversation

@mmaxim
Copy link
Contributor

mmaxim commented Feb 3, 2020

No description provided.

joshblum and others added 8 commits Jan 28, 2020
wip
@mmaxim mmaxim marked this pull request as ready for review Feb 4, 2020
@mmaxim mmaxim requested a review from joshblum Feb 4, 2020
mmaxim added 2 commits Feb 4, 2020
fix
if uid.Eq(msg.ClientHeader.Sender) {
author = "You "
}
return fmt.Sprintf("%screated a new channel #%s", author, msg.ChannelNameMentions[0].TopicName)

This comment has been minimized.

Copy link
@joshblum

joshblum Feb 4, 2020

Member

why not have the sender username ?

@mmaxim mmaxim merged commit 3f78fd5 into master Feb 4, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci Your tests passed on CircleCI!
Details
@mmaxim mmaxim deleted the joshblum/newchmsg-HOTPOT-1808 branch Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.