Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify badging protocol #22378

Merged
merged 6 commits into from Feb 5, 2020
Merged

simplify badging protocol #22378

merged 6 commits into from Feb 5, 2020

Conversation

@mmaxim
Copy link
Contributor

mmaxim commented Feb 5, 2020

Does a couple things:

  • Don't transmit the map of badge counts around anymore, just pick one count value based on current device type.
  • Add rollup stats to badge info.
  • Use stats to simplify various things in JS.
mmaxim added 3 commits Feb 5, 2020
@mmaxim mmaxim requested review from joshblum and keybase/react-hackers Feb 5, 2020
mmaxim added 2 commits Feb 5, 2020
Copy link
Member

joshblum left a comment

lgtm for go

b.log.CDebugf(ctx, "updateWithChat: %s", update)
deviceType := keybase1.DeviceType_DESKTOP

This comment has been minimized.

Copy link
@joshblum

joshblum Feb 5, 2020

Member

why not just b.G().IsMobileAppType()) here instead of threading isMobile?

This comment has been minimized.

Copy link
@mmaxim

mmaxim Feb 5, 2020

Author Contributor

No G here, just thought this was easier.

Copy link
Contributor

hyperobject left a comment

js lgtm

@mmaxim mmaxim merged commit ca44337 into master Feb 5, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit is being built
Details
ci/circleci Your tests passed on CircleCI!
Details
@mmaxim mmaxim deleted the mike/HOTPOT-1583-2 branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.