Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style markdown wrapper box for mobile #22381

Merged
merged 1 commit into from Feb 5, 2020

Conversation

@hyperobject
Copy link
Contributor

hyperobject commented Feb 5, 2020

This PR fixes an issue where attachment captions were centered on mobile instead of left-aligned. The issue was that the Kb.Markdown component doesn't have a wrapper on mobile (intentionally), and so didn't pick up the styles passed to the component, so setting those styles on a wrapper Box2 fixed the issue.

@hyperobject hyperobject requested a review from keybase/react-hackers Feb 5, 2020
@mmaxim
mmaxim approved these changes Feb 5, 2020
@hyperobject hyperobject merged commit 7d199d4 into master Feb 5, 2020
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@hyperobject hyperobject deleted the cori/fix/mobile-attachment-center branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.