Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome msg #22385

Merged
merged 9 commits into from Feb 11, 2020
Merged

Welcome msg #22385

merged 9 commits into from Feb 11, 2020

Conversation

@heronhaye
Copy link
Contributor

heronhaye commented Feb 5, 2020

No description provided.

@heronhaye heronhaye force-pushed the surya/Y2K-1359/teamdevstorage branch from 3f09400 to bccdf3e Feb 5, 2020

const welcomeMessageName = "__welcome_message"

func (h *Server) welcomeStorage() types.ConversationBackedStorage {

This comment has been minimized.

Copy link
@heronhaye

heronhaye Feb 5, 2020

Author Contributor

Is it ok to make the storage struct on-demand, or should I make a long lived WelcomeMessageManager on G containing this storage struct?

@heronhaye heronhaye requested a review from mmaxim Feb 5, 2020
@@ -75,13 +75,13 @@ func (s *Settings) WhitelistAdd(ctx context.Context, uid gregor1.UID, domain str
return nil
}
wr.Whitelist[domain] = true
return s.storage.Put(ctx, uid, settingsWhitelistName, wr)
return s.storage.Put(ctx, uid, chat1.TLFID(uid), settingsWhitelistName, wr)

This comment has been minimized.

Copy link
@mmaxim

mmaxim Feb 7, 2020

Contributor

I don't like this, let's talk on Monday.

@heronhaye heronhaye force-pushed the surya/Y2K-1359/teamdevstorage branch from e9bc275 to 34c8ef5 Feb 10, 2020
@heronhaye

This comment has been minimized.

Copy link
Contributor Author

heronhaye commented Feb 10, 2020

@mmaxim I made teamdevstorage.go as requested

Fix
@mmaxim
mmaxim approved these changes Feb 11, 2020
heronhaye added 2 commits Feb 11, 2020
@heronhaye heronhaye merged commit 77d497a into master Feb 11, 2020
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@heronhaye heronhaye deleted the surya/Y2K-1359/teamdevstorage branch Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.