Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup new conv system msg [HOTPOT-1900] #22422

Merged
merged 3 commits into from Feb 10, 2020
Merged

Fixup new conv system msg [HOTPOT-1900] #22422

merged 3 commits into from Feb 10, 2020

Conversation

@joshblum
Copy link
Member

joshblum commented Feb 7, 2020

  • only send if conv is newly created
  • hook bulk rpc into NewConversationLocal so we get the system msg there too

cc @heronhaye

@joshblum joshblum changed the title Fixup new conv system msg Fixup new conv system msg [HOTPOT-1900] Feb 7, 2020
@joshblum joshblum force-pushed the joshblum/fix-new-conv branch from 6b8a2e6 to b6d4d95 Feb 7, 2020
@joshblum joshblum requested a review from mmaxim Feb 7, 2020
@mmaxim
mmaxim approved these changes Feb 10, 2020
@joshblum joshblum force-pushed the joshblum/fix-new-conv branch from b6d4d95 to bd21612 Feb 10, 2020
@joshblum joshblum merged commit 529598e into master Feb 10, 2020
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@joshblum joshblum deleted the joshblum/fix-new-conv branch Feb 10, 2020
xgess added a commit that referenced this pull request Feb 10, 2020
* call local rpc

* fixup new conv sysmsg

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.