Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont' return handle error, just output #22436

Merged
merged 2 commits into from Feb 7, 2020
Merged

dont' return handle error, just output #22436

merged 2 commits into from Feb 7, 2020

Conversation

@joshblum
Copy link
Member

joshblum commented Feb 7, 2020

previously the entire api loop would fail on a single error

@joshblum joshblum requested a review from mmaxim Feb 7, 2020
@mmaxim
mmaxim approved these changes Feb 7, 2020
@joshblum joshblum force-pushed the joshblum/api-errs branch from 6d5c692 to f923481 Feb 7, 2020
@joshblum joshblum merged commit e4be030 into master Feb 7, 2020
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@joshblum joshblum deleted the joshblum/api-errs branch Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.