Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SimpleSearchInbox and refactor FS share to conv flow #22495

Merged
merged 12 commits into from Feb 12, 2020
Merged

Conversation

@mmaxim
Copy link
Contributor

mmaxim commented Feb 11, 2020

  • Add SimpleSearchInbox to allow for the simplest of searches, along with a response for the blank search.
  • Refactor the FS share to chat flow to not use Redux anymore, and be simpler by using the new RPC.
mmaxim added 11 commits Feb 10, 2020
wip
wip
wip
wip
wip
wip
@mmaxim mmaxim requested a review from keybase/react-hackers Feb 11, 2020
@chrisnojima chrisnojima self-assigned this Feb 12, 2020
@@ -2179,10 +2179,15 @@ function* attachmentsUpload(
logger: Saga.SagaLogger
) {
const {conversationIDKey, paths, titles} = action.payload
let tlfName = action.payload.tlfName

This comment has been minimized.

Copy link
@chrisnojima

chrisnojima Feb 12, 2020

Contributor

you can use the form above

let {tlfName} = action.payload
@mmaxim mmaxim merged commit 14d39dd into master Feb 12, 2020
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@mmaxim mmaxim deleted the mike/HOTPOT-1884 branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.