Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default channels support for client #22497

Merged
merged 3 commits into from Feb 12, 2020
Merged

Conversation

@joshblum
Copy link
Member

joshblum commented Feb 11, 2020

cli in action:

$ kb chat default-channels teamteam --channel newchannel
Default channels for teamteam are:
        #general
        #newchannel
@joshblum joshblum requested a review from mmaxim Feb 11, 2020
@joshblum joshblum force-pushed the joshblum/default-ii-HOTPOT-1847 branch from b12c865 to a863cb3 Feb 11, 2020
@mmaxim
mmaxim approved these changes Feb 11, 2020
if err != nil {
return res, err
}
convs := []chat1.ConversationLocal{}

This comment has been minimized.

Copy link
@mmaxim

mmaxim Feb 11, 2020

Contributor

I'm pretty sure it will get filtered with the topic type filter on the read

@joshblum joshblum merged commit 1533515 into master Feb 12, 2020
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@joshblum joshblum deleted the joshblum/default-ii-HOTPOT-1847 branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.