Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter bots from info panel members #22534

Closed
wants to merge 3 commits into from

Conversation

@hyperobject
Copy link
Contributor

hyperobject commented Feb 12, 2020

Filters bot usernames from the "Members" tab in the info panel for all teams, and adds an icon with a tooltip if a bot is in a channel in a big team.

@hyperobject hyperobject requested a review from keybase/react-hackers Feb 12, 2020
@@ -65,6 +66,11 @@ export const Bot = (props: BotProps) => {
{usernameDisplay}
{lower}
</Kb.Box2>
{showInChannel && (

This comment has been minimized.

Copy link
@mmaxim

mmaxim Feb 13, 2020

Contributor

I was thinking this would just always be on the screen, and be more in the negative direction. That is, there would be a label indicating a bot is not in the channel as part of the row.

This comment has been minimized.

Copy link
@hyperobject

hyperobject Feb 13, 2020

Author Contributor

gotcha, so more like the add to channel button but without the action associated

@hyperobject

This comment has been minimized.

Copy link
Contributor Author

hyperobject commented Feb 13, 2020

cc @keybase/design how's this look?
Screen Shot 2020-02-13 at 10 23 17 AM

@mmaxim
mmaxim approved these changes Feb 13, 2020
@hyperobject

This comment has been minimized.

Copy link
Contributor Author

hyperobject commented Feb 13, 2020

gonna close this since design wanted to go a different route on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.