Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record gzip size in instrumentation #22536

Merged
merged 2 commits into from Feb 13, 2020
Merged

Conversation

@joshblum
Copy link
Member

joshblum commented Feb 12, 2020

No description provided.

@joshblum joshblum requested review from patrickxb and mmaxim Feb 12, 2020
@mmaxim
mmaxim approved these changes Feb 13, 2020
Copy link
Contributor

mmaxim left a comment

I would profile just to make sure this doesn't show up at all too. Also nice sync.Pool usage

@joshblum joshblum force-pushed the joshblum/network-gzip-HOTPOT-1955 branch from 3cfa223 to 8a50107 Feb 13, 2020
@joshblum joshblum merged commit d563377 into master Feb 13, 2020
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@joshblum joshblum deleted the joshblum/network-gzip-HOTPOT-1955 branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.