Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix com.apple.macl protected drag and drop #22569

Open
wants to merge 3 commits into
base: master
from
Open

Conversation

@songgao
Copy link
Contributor

songgao commented Feb 14, 2020

No description provided.

@songgao songgao requested review from chrisnojima, joshblum and mmaxim Feb 14, 2020
@songgao songgao force-pushed the songgao/HOTPOT-1957 branch 2 times, most recently from 4a781f1 to 7387803 Feb 14, 2020
@chrisnojima chrisnojima self-assigned this Feb 14, 2020
@mmaxim

This comment has been minimized.

Copy link
Contributor

mmaxim commented Feb 14, 2020

You shouldn’t need this extra delete logic, there is a method called makeuploadtempfile which should do what you need. Can copy the flow for pasting an attachment into chat

Copy link
Contributor

mmaxim left a comment

Same goes for copy to tmp, the destination should be what the service gives back. I assume this if for the case for dragging an attachment in that isn’t a real file yet?

@songgao

This comment has been minimized.

Copy link
Contributor Author

songgao commented Feb 14, 2020

I assume this if for the case for dragging an attachment in that isn’t a real file yet?

It’s a file on the file system, but with that date which adds the protection that it can only be accessed from the process that this is dropped on to.

I’ll look for that RPC in service

@songgao songgao requested a review from mmaxim Feb 14, 2020
@songgao songgao force-pushed the songgao/HOTPOT-1957 branch from 5f834fb to d0d5f1e Feb 14, 2020
@mmaxim
mmaxim approved these changes Feb 17, 2020
@songgao

This comment has been minimized.

Copy link
Contributor Author

songgao commented Feb 17, 2020

@chrisnojima importing os is failing here. We are only using the tmpdir here for the KBFS part. In the long run I wanna move all these KBFS upload logic to Go by having an upload manager there (similar to Files download, or chat upload). But short term is there a way to make os import work, or should I just hard code a path in there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.