Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear conv source on stale topic state #23056

Merged
merged 1 commit into from Mar 18, 2020
Merged

Conversation

@joshblum
Copy link
Member

joshblum commented Mar 13, 2020

No description provided.

@joshblum joshblum requested a review from mmaxim Mar 13, 2020
@mmaxim

This comment has been minimized.

Copy link
Contributor

mmaxim commented Mar 16, 2020

Is there any evidence this fixes anything?

@joshblum

This comment has been minimized.

Copy link
Member Author

joshblum commented Mar 16, 2020

In the logs a cached invalid max msg was used which is what motivated this change. It doesn't fix the specific problem which seems to be on the server but I think it's a good change regardless

@mmaxim
mmaxim approved these changes Mar 18, 2020
@joshblum joshblum merged commit 00bec8c into master Mar 18, 2020
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@joshblum joshblum deleted the joshblum/topicnamestate-HOTPOT-2174 branch Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.