Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom emojis cross team #23190

Merged
merged 15 commits into from Mar 24, 2020
Merged

custom emojis cross team #23190

merged 15 commits into from Mar 24, 2020

Conversation

@mmaxim
Copy link
Contributor

mmaxim commented Mar 21, 2020

cc @keybase/hotpotatosquad

The idea here is we create a new conversation on the destination team which holds the attachments synced from some other team. The topic name on the synced conversation corresponds to the source conversation ID. We can optimize for not re-uploading the image every time be comparing the new plaintext hash on the attachments from the source and destination emoji conv.

Also allows for collision resolution between emoji aliases from different teams by encoding the mapping on the message itself.

mmaxim added 12 commits Mar 21, 2020
wip
wip
wip
wip
wip
wip
wip
wip
Conflicts:
	shared/constants/types/rpc-chat-gen.tsx
wip
@mmaxim mmaxim requested a review from joshblum Mar 23, 2020
@mmaxim mmaxim marked this pull request as ready for review Mar 23, 2020
go/chat/emojisource.go Outdated Show resolved Hide resolved
go/chat/emojisource.go Outdated Show resolved Hide resolved
go/chat/emojisource.go Outdated Show resolved Hide resolved
go/chat/emojisource.go Outdated Show resolved Hide resolved
mmaxim added 3 commits Mar 24, 2020
@mmaxim mmaxim requested a review from joshblum Mar 24, 2020

func (s *DevConvEmojiSource) isHarvestContext(ctx context.Context) bool {
val := ctx.Value(harvestOpKey)
if _, ok := val.(bool); ok {

This comment has been minimized.

Copy link
@joshblum

joshblum Mar 24, 2020

Member

return ok

@mmaxim mmaxim merged commit 082339b into master Mar 24, 2020
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@mmaxim mmaxim deleted the mike/HOTPOT-2185 branch Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.