Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deselectedConversation action. request meta on deselect to update draft #23255

Merged
merged 2 commits into from Mar 25, 2020

Conversation

@chrisnojima
Copy link
Contributor

chrisnojima commented Mar 25, 2020

No description provided.

… draft
@chrisnojima chrisnojima requested review from mmaxim and keybase/react-hackers Mar 25, 2020
@@ -3613,6 +3622,12 @@ const maybeChatTabSelected = (action: RouteTreeGen.OnNavChangedPayload) => {
return false
}

const updateDraftState = (action: Chat2Gen.DeselectedConversationPayload) =>
Chat2Gen.createMetaNeedsUpdating({

This comment has been minimized.

Copy link
@mmaxim

mmaxim Mar 25, 2020

Contributor

I think just do createMetaRequestTrusted with force set to true, otherwise I don't think this will go.

This comment has been minimized.

Copy link
@chrisnojima

chrisnojima Mar 25, 2020

Author Contributor

Ok I'll look tomorrow or you can. When I tested it it always worked. I put some stuff. Click away. It requested and the snippet showed the draft state

@mmaxim
mmaxim approved these changes Mar 25, 2020
@chrisnojima chrisnojima merged commit ef062be into master Mar 25, 2020
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@chrisnojima chrisnojima deleted the nojima/HOTPOT-deselected-action branch Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.