Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emoji picker works #23288

Merged
merged 5 commits into from Mar 26, 2020
Merged

emoji picker works #23288

merged 5 commits into from Mar 26, 2020

Conversation

@songgao
Copy link
Contributor

songgao commented Mar 26, 2020

  • reafactor data caching
  • add the desktop bookmark bar for jumping to different sections
  • make custom emojis work with filtering
  • other fixes and tweaks
@songgao songgao requested review from hyperobject, keybase/react-hackers and chrisnojima Mar 26, 2020
@mmaxim mmaxim self-assigned this Mar 26, 2020
@mmaxim

This comment has been minimized.

Copy link
Contributor

mmaxim commented Mar 26, 2020

This just throws a JS error for me, I'll fix.

@mmaxim

This comment has been minimized.

Copy link
Contributor

mmaxim commented Mar 26, 2020

Problem is that if a custom emoji is in the frequent list

@chrisnojima

This comment has been minimized.

Copy link
Contributor

chrisnojima commented Mar 26, 2020

this will work eventually right

@mmaxim

This comment has been minimized.

Copy link
Contributor

mmaxim commented Mar 26, 2020

Going to merge this since it allows me to use the picker again for customs (master is broken for me). But @songgao, there needs to be code in here to make it so the frequent section can pick up customs.

@mmaxim
mmaxim approved these changes Mar 26, 2020
@mmaxim mmaxim merged commit 80e64bd into master Mar 26, 2020
0 of 2 checks passed
0 of 2 checks passed
ci/circleci CircleCI is running your tests
Details
continuous-integration/jenkins/pr-head This commit is being built
Details
@mmaxim mmaxim deleted the songgao/HOTPOT-2244 branch Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.