Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark chat as unread #25550

Merged
merged 12 commits into from Mar 16, 2023
Merged

Mark chat as unread #25550

merged 12 commits into from Mar 16, 2023

Conversation

joshblum
Copy link
Member

@joshblum joshblum commented Mar 13, 2023 •
edited

Beginnings of marking a chat as unread. Please take a look and feel free to push changes directly if something sticks out. The basic flow is mostly working with a few bugs:

  • orange line is rendered correctly but unread count is off by one
  • orange line instantly clears when entering a thread, it should remain
  • add swipe action to mark as unread from a small inbox row

depends on server changes in https://github.com/keybase/keybase/pull/5723/files

@chrisnojima
Copy link
Contributor

why is 'orange line clears when entering a thread' true?

@joshblum
Copy link
Member Author

orange line clearing is the bug!

@joshblum joshblum changed the title WIP: mark chat message as unread Mark chat as unread Mar 14, 2023
chrisnojima
chrisnojima approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@chrisnojima chrisnojima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 liner than it can go in, i'll ticket the swipe tnx

@joshblum
Copy link
Member Author

Closes #21586

@joshblum joshblum merged commit c67fbe0 into master Mar 16, 2023
2 checks passed
@joshblum joshblum deleted the joshblum/mark-as-unread branch March 16, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisnojima chrisnojima chrisnojima approved these changes

@mmaxim mmaxim Awaiting requested review from mmaxim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshblum @chrisnojima