Conversation list mobile #5813
Merged
Conversation list mobile #5813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commits 6f75f65...dd06168 introduce visual changes on linux. 🔎 9 changed
|
|
The commits 6f75f65...a9eb9bc introduce visual changes on linux. 🔎 9 changed
|
chromakode
approved these changes
Feb 14, 2017
shared/common-adapters/markdown.js
Outdated
| return exists | ||
| ? <Emoji {...this.props} /> | ||
| : <Text | ||
| type='Body' |
shared/local-debug-live.js
Outdated
| @@ -8,10 +8,10 @@ import {envVarDebugJson, isTesting} from './local-debug' | |||
|
|
|||
| // Shared settings | |||
| const dumbFilterJson = (envVarDebugJson() || {}).dumbFilter || '' | |||
| const dumbFilterOverride = '' // Changing this will apply during a hot reload session | |||
| const dumbFilterOverride = 'conversations' // Changing this will apply during a hot reload session | |||
shared/local-debug-live.js
Outdated
|
|
||
| export const dumbFilter = dumbFilterOverride || dumbFilterJson | ||
|
|
||
| // Mobile only settings | ||
| export const dumbIndex = 0 | ||
| export const dumbIndex = 9 |
chrisnojima
added a commit
that referenced
this pull request
Feb 14, 2017
#5812) * added watchman config. added dummy chat component files. fix text eating taps. rename yourekey compnent. add simulator flag to native. add notification listeners * dumb chat cross platform * conversation list refactor * undo whitespace * lint fixes * plumb through backgroundColor * Conversation list mobile (#5813) * usernames working * bottom line working * WIP * fixup merge * fix overflow on row bottom * pr fixes * min width on convo list * WIP * lineClamp messes up truncation for some reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keybase/react-hackers this gets the conversation list dumb rendering done