Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unfurl and flip support #142

Merged
merged 4 commits into from Jun 3, 2019

Conversation

Projects
None yet
2 participants
@pzduniak
Copy link
Member

commented May 29, 2019

No description provided.

pzduniak added some commits May 29, 2019

@pzduniak

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2019

Fully functional, requires keybase/client#17785.
Timeout hack required to avoid https://keybase.atlassian.net/browse/CORE-11027

@pzduniak

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2019

@malgorithms I don't know the consequences of killing the processes. Will require some feedback from Mike on 11027.

@pzduniak pzduniak marked this pull request as ready for review Jun 1, 2019

@pzduniak pzduniak requested a review from malgorithms Jun 1, 2019

@malgorithms
Copy link
Contributor

left a comment

LGTM - could take a bit to explain what unfurling is in the docs. I don't think that's a known term by most people.

@pzduniak pzduniak merged commit c624abc into master Jun 3, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@pzduniak pzduniak deleted the pzduniak/unfurl-and-flips branch Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.