Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse webhook bodies #116

Merged
merged 1 commit into from Feb 4, 2020
Merged

parse webhook bodies #116

merged 1 commit into from Feb 4, 2020

Conversation

@joshblum
Copy link
Member

joshblum commented Feb 3, 2020

addresses #112

@joshblum joshblum requested a review from mmaxim Feb 3, 2020
@@ -55,7 +72,7 @@ func (h *HTTPSrv) handleHook(w http.ResponseWriter, r *http.Request) {
}
msg, err := h.getMessage(r)
if err != nil {
h.Debug("handleHook: failed to find message: %s", err)
h.Errorf("handleHook: failed to find message: %s", err)

This comment has been minimized.

Copy link
@mmaxim

mmaxim Feb 4, 2020

Contributor

I"m not sure about this, seems like we will pick up a lot of noise

This comment has been minimized.

Copy link
@joshblum

joshblum Feb 4, 2020

Author Member

I wanted to see what came through here for a bit if there was anything useful and I'll turn it off if not

@joshblum joshblum requested a review from mmaxim Feb 4, 2020
@@ -21,7 +25,7 @@ func NewHTTPSrv(debugConfig *base.ChatDebugOutputConfig, db *DB) *HTTPSrv {
h.HTTPSrv = base.NewHTTPSrv(debugConfig)
rtr := mux.NewRouter()
rtr.HandleFunc("/webhookbot", h.handleHealthCheck)
rtr.HandleFunc("/webhookbot/{id:[A-Za-z0-9_]+}", h.handleHook)
rtr.HandleFunc("/webhookbot/{id:[A-Za-z0-9_-]+}", h.handleHook)

This comment has been minimized.

Copy link
@joshblum

joshblum Feb 4, 2020

Author Member

this busted a bunch of webhooks

@mmaxim
mmaxim approved these changes Feb 4, 2020
@joshblum joshblum merged commit 0596e11 into master Feb 4, 2020
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@joshblum joshblum deleted the joshblum/webhook branch Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.