Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hidden `!botlog` command to fetch cloudwatch logs #61

Merged
merged 6 commits into from Jan 15, 2020

Conversation

@joshblum
Copy link
Member

joshblum commented Jan 14, 2020

No description provided.

@joshblum joshblum requested a review from mmaxim Jan 14, 2020
base/base.go Outdated Show resolved Hide resolved
@joshblum joshblum requested a review from mmaxim Jan 14, 2020
base/options.go Outdated Show resolved Hide resolved
webhookbot/main.go Outdated Show resolved Hide resolved
@joshblum joshblum requested a review from mmaxim Jan 14, 2020
@joshblum

This comment has been minimized.

Copy link
Member Author

joshblum commented Jan 15, 2020

@mmaxim this is ready

@mmaxim
mmaxim approved these changes Jan 15, 2020
@joshblum joshblum merged commit ce93028 into master Jan 15, 2020
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@joshblum joshblum deleted the joshblum/cloudwatch-HOTPOT-1662 branch Jan 15, 2020
if err := bs.Go(); err != nil {
fmt.Printf("error running chat loop: %v\n", err)
return 3

This comment has been minimized.

Copy link
@Daniel-Wang

Daniel-Wang Jan 17, 2020

Contributor

@joshblum did you want to return 3 after all the other fmt.Printf("error running chat loop: %v\n", err) too?
Seems like only in githubbot this change exists.
Was applying some retroactive changes to gitlabbot so I was looking at the PR XD

This comment has been minimized.

Copy link
@joshblum

joshblum Jan 17, 2020

Author Member

yes that sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.