New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove seemingly-unused giant array of USBSetup structs #4

Merged
merged 4 commits into from Oct 17, 2017

Conversation

Projects
None yet
2 participants
@jamesnvc
Contributor

jamesnvc commented Oct 17, 2017

Having HostOS detection enable in Kaleidoscope firmware causes a 256 byte (10%) increase in SRAM usage; by removing this array, the usage only increases by 25 bytes.

I don't have access to a device to test this on, although as far as I can tell, the only place where the usbSetups array is used is in one of the examples in this repo.

@obra

This comment has been minimized.

Show comment
Hide comment
@obra

obra Oct 17, 2017

Member

Can you throw these things behind #ifdef DEBUG? I use them as dev tools

Member

obra commented Oct 17, 2017

Can you throw these things behind #ifdef DEBUG? I use them as dev tools

@obra

This comment has been minimized.

Show comment
Hide comment
Member

obra commented Oct 17, 2017

@jamesnvc

This comment has been minimized.

Show comment
Hide comment
@jamesnvc

jamesnvc Oct 17, 2017

Contributor

Ah yeah, the DumpFingerprint.ino example uses the usbSetups field. Is there a way to make Travis compile that specific file with -DDEBUG?

Contributor

jamesnvc commented Oct 17, 2017

Ah yeah, the DumpFingerprint.ino example uses the usbSetups field. Is there a way to make Travis compile that specific file with -DDEBUG?

@jamesnvc

This comment has been minimized.

Show comment
Hide comment
@jamesnvc

jamesnvc Oct 17, 2017

Contributor

Oh, I guess I can just do #define DEBUG in the example.

I have not done C in a while

Contributor

jamesnvc commented Oct 17, 2017

Oh, I guess I can just do #define DEBUG in the example.

I have not done C in a while

@obra obra merged commit 5ba25f4 into keyboardio:master Oct 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment