This repository has been archived by the owner. It is now read-only.

Finer stickability control #45

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@jamadagni
Copy link

jamadagni commented Jul 18, 2018

Allows controlling the “stickability” of individual layers.

Unfortunately this is an API-breaking change as it removes the earlier and now superseded coarser-grained boolean properties.

@algernon algernon self-assigned this Jul 25, 2018

@algernon

This comment has been minimized.

Copy link
Member

algernon commented Oct 21, 2018

I like the direction where this is going. I'm going to rebase it on top of current Kaleidoscope, and instead of breaking backwards compat, I'll rework it a little to allow the old properties to work still.

My plan is to keep those as-is, and introduce a pair of flags: when the new setter/getters are used, they'll flip the flag to true. In that case, the plugin will use the new stuff, otherwise it will fall back to the old ones. The documentation will only mention the new APIs, except in the UPGRADING part, where a migration path will be laid out.

algernon added a commit to keyboardio/Kaleidoscope that referenced this pull request Oct 27, 2018

OneShot: Implement finer stickability controls
Based on the work of Shriramana Sharma (@jamadagni) in
keyboardio/Kaleidoscope-OneShot#45, this implements finer stickability controls
for `OneShot`, allowing one to set stickability on a per-key basis. The old
`.double_tap_sticky` and `.double_tap_sticky_layers` properties still work, but
are deprecated.

Signed-off-by: Gergely Nagy <algernon@keyboard.io>

algernon added a commit to keyboardio/Kaleidoscope that referenced this pull request Oct 27, 2018

OneShot: Implement finer stickability controls
Based on the work of Shriramana Sharma (@jamadagni) in
keyboardio/Kaleidoscope-OneShot#45, this implements finer stickability controls
for `OneShot`, allowing one to set stickability on a per-key basis. The old
`.double_tap_sticky` and `.double_tap_sticky_layers` properties still work, but
are deprecated.

Signed-off-by: Gergely Nagy <algernon@keyboard.io>
@algernon

This comment has been minimized.

Copy link
Member

algernon commented Oct 27, 2018

I took these changes, massaged them around a bit, and keyboardio/Kaleidoscope#447 was born. It has a different API, and maintains backwards compatibility too, but still allows you to achieve the same things this PR was allowing one to.

Please comment on that issue with regards to API and code, I'm going to close this one.

Thanks a lot for your work on this feature! <3

@algernon algernon closed this Oct 27, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.