Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active modifier LED highlight doesn't work all for the first ~minute after boot #670

Closed
wearpants opened this issue Jul 31, 2019 · 3 comments

Comments

@wearpants
Copy link

commented Jul 31, 2019

Using OneShot mode, the active modifier LED plugin doesn't highlight any keys for the first minute or so after boot, even though the modifiers work properly.

Might be the first few dozen keypresses rather than time-based.

@gedankenexperimenter

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

My guess is that it's being overridden by the BootGreeting effect.

@algernon

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

I asked @wearpants on Discord, and he confirmed: if one changes layers, the highlight will work after that. The problem is caching. ActiveModColor will scan the keymap on setup and at layer change. For some reason, the scan on setup doesn't yield the results we want.

@algernon

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

I think I have a fix for this, a simple one too. Unfortunately, while trying to verify if it really works, I discovered that ActiveModColor doesn't seem to restore the original color. Not sure whether that's an ActiveModColor or a Colormap issue yet, though.

algernon added a commit that referenced this issue Aug 16, 2019

ActiveModColor: Cache the list of modifiers at setup time too
In order for the plugin to work without having to switch layers once, it needs
to scan the keymap for modifiers at setup time too. We do this by calling
`onLayerChange()`, which already does that.

Fixes #670.

Signed-off-by: Gergely Nagy <algernon@keyboard.io>

@obra obra closed this in #674 Aug 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.