[Bug] Animations use fix value for height #90

Closed
pboos opened this Issue Apr 2, 2013 · 1 comment

Projects

None yet

2 participants

@pboos

Currently the default in and out animations use -50 offset. This does not consider different densities. For example on my device the height of the view is 58px. So 8 pixel will not be animated and it will result in a jump.

This specially affects custom views, since the height there can be any size.

I already got this fixed here and will send a pull request in a few minutes.

@pboos pboos added a commit to pboos/Crouton that referenced this issue Apr 2, 2013
@pboos pboos Fix: Use height of crouton view for animation (fixes #90) 1bdb071
@keyboardsurfer

Thanks for the pull request. The solution will up with version 1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment