Fix: Custom views should have MATCH_PARENT as default width #93

Merged
merged 1 commit into from Apr 2, 2013

Conversation

Projects
None yet
2 participants
@pboos
Contributor

pboos commented Apr 2, 2013

I was expecting that custom views without LayoutParams will receive MATCH_PARENT for their width. This seems to not be the case in the current implementation.
Of course one can fix this by inflating it correctly. But for that the parent view needs to be available. Or one can just set the LayoutParams. Both not a big problem. But I think the default should be MATCH_PARENT.

About breaking previous custom views. I doubt anyone really used custom views, since there are many problems with them (see my other pull requests). Specially the inability to set duration on custom views makes them come and disappear without enough time to read them.

@keyboardsurfer keyboardsurfer merged commit d5fc7b8 into keyboardsurfer:develop Apr 2, 2013

@keyboardsurfer

This comment has been minimized.

Show comment Hide comment
@keyboardsurfer

keyboardsurfer Apr 2, 2013

Owner

And now I see why MATCH_PARENT is a good idea in this case. Thanks!

Owner

keyboardsurfer commented Apr 2, 2013

And now I see why MATCH_PARENT is a good idea in this case. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment