diff --git a/operator/src/main/java/org/keycloak/operator/controllers/KeycloakDeploymentDependentResource.java b/operator/src/main/java/org/keycloak/operator/controllers/KeycloakDeploymentDependentResource.java index 4f85b9d99eac..27be028b802d 100644 --- a/operator/src/main/java/org/keycloak/operator/controllers/KeycloakDeploymentDependentResource.java +++ b/operator/src/main/java/org/keycloak/operator/controllers/KeycloakDeploymentDependentResource.java @@ -65,6 +65,8 @@ @KubernetesDependent(labelSelector = Constants.DEFAULT_LABELS_AS_STRING) public class KeycloakDeploymentDependentResource extends CRUDKubernetesDependentResource { + static final String JGROUPS_DNS_QUERY_PARAM = "-Djgroups.dns.query="; + public static final String OPTIMIZED_ARG = "--optimized"; @Inject @@ -209,6 +211,7 @@ private StatefulSet createBaseDeployment(Keycloak keycloakCR, Context if (customImage.isPresent()) { containerBuilder.addToArgs(OPTIMIZED_ARG); } + containerBuilder.addToArgs(0, getJGroupsParameter(keycloakCR)); // probes var tlsConfigured = isTlsConfigured(keycloakCR); @@ -271,6 +274,10 @@ private StatefulSet createBaseDeployment(Keycloak keycloakCR, Context return baseDeployment; } + private static String getJGroupsParameter(Keycloak keycloakCR) { + return JGROUPS_DNS_QUERY_PARAM + KeycloakDiscoveryServiceDependentResource.getName(keycloakCR) +"." + keycloakCR.getMetadata().getNamespace(); + } + private void addEnvVarsAndWatchSecrets(StatefulSet baseDeployment, Keycloak keycloakCR) { var firstClasssEnvVars = distConfigurator.configureDistOptions(keycloakCR); @@ -351,12 +358,6 @@ private List getDefaultAndAdditionalEnvVars(Keycloak keycloakCR, String .endValueFrom() .build()); - envVars.add( - new EnvVarBuilder() - .withName("jgroups.dns.query") - .withValue(getName(keycloakCR) + Constants.KEYCLOAK_DISCOVERY_SERVICE_SUFFIX +"." + keycloakCR.getMetadata().getNamespace()) - .build()); - return envVars; } diff --git a/operator/src/main/java/org/keycloak/operator/controllers/KeycloakRealmImportJobDependentResource.java b/operator/src/main/java/org/keycloak/operator/controllers/KeycloakRealmImportJobDependentResource.java index 2d4310d5b120..6acb9b7badb2 100644 --- a/operator/src/main/java/org/keycloak/operator/controllers/KeycloakRealmImportJobDependentResource.java +++ b/operator/src/main/java/org/keycloak/operator/controllers/KeycloakRealmImportJobDependentResource.java @@ -38,6 +38,7 @@ import org.keycloak.operator.crds.v2alpha1.realmimport.KeycloakRealmImport; import java.util.List; +import java.util.Set; import static org.keycloak.operator.controllers.KeycloakDistConfigurator.getKeycloakOptionEnvVarName; @@ -76,7 +77,9 @@ protected Job desired(KeycloakRealmImport primary, Context var cacheEnvVarName = getKeycloakOptionEnvVarName("cache"); var healthEnvVarName = getKeycloakOptionEnvVarName("health-enabled"); - envvars.removeIf(e -> e.getName().equals(cacheEnvVarName) || e.getName().equals(healthEnvVarName)); + var cacheStackEnvVarName = getKeycloakOptionEnvVarName("cache-stack"); + var toRemove = Set.of(cacheEnvVarName, healthEnvVarName, cacheStackEnvVarName); + envvars.removeIf(e -> toRemove.contains(e.getName())); // The Job should not connect to the cache envvars.add(new EnvVarBuilder().withName(cacheEnvVarName).withValue("local").build()); diff --git a/operator/src/test/java/org/keycloak/operator/testsuite/integration/BaseOperatorTest.java b/operator/src/test/java/org/keycloak/operator/testsuite/integration/BaseOperatorTest.java index d08b0b4d418b..a3a298080f6c 100644 --- a/operator/src/test/java/org/keycloak/operator/testsuite/integration/BaseOperatorTest.java +++ b/operator/src/test/java/org/keycloak/operator/testsuite/integration/BaseOperatorTest.java @@ -319,6 +319,8 @@ public void afterEach(QuarkusTestMethodContext context) { logFailed(k8sclient.apps().deployments().withName("keycloak-operator"), Deployment::getStatus); } logFailed(k8sclient.apps().statefulSets().withName(POSTGRESQL_NAME), StatefulSet::getStatus); + k8sclient.pods().withLabel("app", "keycloak-realm-import").list().getItems().stream() + .forEach(pod -> logFailed(k8sclient.pods().resource(pod), Pod::getStatus)); } finally { cleanup(); } diff --git a/operator/src/test/java/org/keycloak/operator/testsuite/integration/KeycloakDeploymentTest.java b/operator/src/test/java/org/keycloak/operator/testsuite/integration/KeycloakDeploymentTest.java index a327a941e390..23ba52cb33a0 100644 --- a/operator/src/test/java/org/keycloak/operator/testsuite/integration/KeycloakDeploymentTest.java +++ b/operator/src/test/java/org/keycloak/operator/testsuite/integration/KeycloakDeploymentTest.java @@ -489,7 +489,7 @@ public void testCustomImage() { .list() .getItems(); - assertThat(pods.get(0).getSpec().getContainers().get(0).getArgs()).containsExactly("--verbose", "start", "--optimized"); + assertThat(pods.get(0).getSpec().getContainers().get(0).getArgs()).endsWith("--verbose", "start", "--optimized"); } @Test @@ -512,7 +512,7 @@ public void testCustomImageWithImagePullSecrets() { .list() .getItems(); - assertThat(pods.get(0).getSpec().getContainers().get(0).getArgs()).containsExactly("--verbose", "start", "--optimized"); + assertThat(pods.get(0).getSpec().getContainers().get(0).getArgs()).endsWith("--verbose", "start", "--optimized"); assertThat(pods.get(0).getSpec().getImagePullSecrets().size()).isEqualTo(1); assertThat(pods.get(0).getSpec().getImagePullSecrets().get(0).getName()).isEqualTo(imagePullSecretName); } diff --git a/operator/src/test/java/org/keycloak/operator/testsuite/unit/PodTemplateTest.java b/operator/src/test/java/org/keycloak/operator/testsuite/unit/PodTemplateTest.java index 3d672e34d5c6..888b50801313 100644 --- a/operator/src/test/java/org/keycloak/operator/testsuite/unit/PodTemplateTest.java +++ b/operator/src/test/java/org/keycloak/operator/testsuite/unit/PodTemplateTest.java @@ -194,8 +194,8 @@ public void testCommandsAndArgsAreMerged() { // Assert assertEquals(1, podTemplate.getSpec().getContainers().get(0).getCommand().size()); assertEquals(command, podTemplate.getSpec().getContainers().get(0).getCommand().get(0)); - assertEquals(1, podTemplate.getSpec().getContainers().get(0).getArgs().size()); - assertEquals(arg, podTemplate.getSpec().getContainers().get(0).getArgs().get(0)); + assertEquals(2, podTemplate.getSpec().getContainers().get(0).getArgs().size()); + assertEquals(arg, podTemplate.getSpec().getContainers().get(0).getArgs().get(1)); } @Test