KEYCLOAK-1222 - BasicAuth KeycloakSecurityContext token issue

[panga]

No description provided.

[mposolda]

Thanks for the fix and PR!

One small thing - since the issue is just for Basic authentication, is it possible to fix it in BasicAuthRequestAuthenticator instead of BearerTokenRequestAuthenticator? I believe you can set tokenString in the BasicAuthRequestAuthenticator.authenticate right before invoking authenticateToken. What do you think?

[panga]

@mposolda it's another approach, but I agree. PR updated.
IMHO that class should have a refactoring.
It's strange BasicAuthRequestAuthenticator extends BearerTokenRequestAuthenticator.

[mposolda]

Merged, thanks! I am not sure about needed refactoring as there is some common code between BasicAuthRequestAuthenticator and BearerTokenRequestAuthenticator. Fact is that whole BasicAuthRequestAuthenticator and support for basic authentication is kind of corner case, which is useful for legacy applications, but we don't officially recommend to use it (not sure if it's even documented in our user guide).