Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KEYCLOAK-5806] - Create policy button to associated policies #4834

Merged
merged 4 commits into from Dec 17, 2017

Conversation

Projects
None yet
2 participants
@pedroigor
Copy link
Contributor

commented Dec 11, 2017

Please don't merge yet.

@patriot1burke

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2017

I tried this out, I don't see the "+" button anywhere. Safari and Opera on OSX.

@pedroigor

This comment has been minimized.

Copy link
Contributor Author

commented Dec 14, 2017

@patriot1burke, actually what I have now is a "Create Button". And this button was added only to Aggregate Policy UI, when you are creating or updating this type of policy.

I'm adding the same button now to permission (resource and scope) pages. I think I also need to check your fine-grained permission pages (user, token exchange, etc) ...

@pedroigor

This comment has been minimized.

Copy link
Contributor Author

commented Dec 14, 2017

More tests were added. If you try run org.keycloak.testsuite.console.authorization.AggregatePolicyManagementTest#testCreateWithChildAndSelectedPolicy you will see my changes in action.

@pedroigor pedroigor force-pushed the pedroigor:KEYCLOAK-5806 branch from 8510404 to bae3598 Dec 15, 2017

@pedroigor pedroigor force-pushed the pedroigor:KEYCLOAK-5806 branch from bae3598 to 5d7ba39 Dec 16, 2017

@patriot1burke patriot1burke merged commit 118e998 into keycloak:master Dec 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.