[KEYCLOAK-12612][KEYCLOAK-12944] Fix validation of SAML destination URLs #6791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stianst
requested changes
Feb 17, 2020
services/src/main/java/org/keycloak/protocol/saml/SamlService.java
Outdated
Show resolved
Hide resolved
stianst
reviewed
Feb 17, 2020
...on-arquillian/tests/base/src/test/java/org/keycloak/testsuite/saml/SamlReverseProxyTest.java
Outdated
Show resolved
Hide resolved
- no longer compare them to the server absolutePath; instead use the base URI to build the validation URL
stianst
approved these changes
Feb 18, 2020
There was a problem hiding this comment.
LGTM - would like @pedroigor or @hmlnarik to review as well
pedroigor
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links to Jiras: https://issues.redhat.com/browse/KEYCLOAK-12612
https://issues.redhat.com/browse/KEYCLOAK-12944