KEYCLOAK-19743 Fix null username in ldap #8717
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
MembershipType.getGroupMembers
when username is null (invalid configuration).Context: method
MembershipType.getGroupMembers
return list of usernames. Username can be fetched by:userDn.getFirstRdn().getAttrValue(ldapConfig.getRdnLdapAttribute())
LDAPUtils.getUsername(ldapUser, ldapConfig)
Inside
LDAPUtils.getUsername(ldapUser, ldapConfig)
null check is look like:But in case
userDn.getFirstRdn().getAttrValue(ldapConfig.getRdnLdapAttribute())
there are no null verification.So
MembershipType.getGroupMembers
get return list withnulls
. This behavior breaksUserCacheSession:getUserByUsername
when we transform username to lowercaseI suggest to throw exception
ModelException
likeLDAPUtils.getUsername
do.Issue: https://issues.redhat.com/browse/KEYCLOAK-19743