-
Notifications
You must be signed in to change notification settings - Fork 71
push-model: implement continuous attestation with configurable intervals #1066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5a6f215 to
a4a0840
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
a4a0840 to
32d43d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, define const values to avoid "magic numbers":
measurement_interval_seconds: 60, -> measurement_interval_seconds: DEFAULT_MEASUREMENT_INTERVAL_SECONDS
32d43d3 to
fbf3921
Compare
After the first successful attestation, the agent now waits for a configurable interval before repeating the attestation process by returning to the Negotiating state, creating a continuous attestation loop. The interval between the attestations is currently fixed, but in the future, the verifier will provide this information in its response to the attestation, so we can parse it from there and use it instead. Currently, the interval between sending the measurements is defined as 60s, but can be configured with the --attestation-interval-seconds switch. Signed-off-by: Sergio Correia <scorreia@redhat.com>
fbf3921 to
96ea82c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I tested the continuous attestation against current state of the Verifier from the keylime/keylime#1693 and it worked well in the happy execution path.
After the first successful attestation, the agent now waits for a
configurable interval before repeating the attestation process by
returning to the Negotiating state, creating a continuous attestation
loop.
The interval between the attestations is currently fixed, but in the
future, the verifier will provide this information in its response to
the attestation, so we can parse it from there and use it instead.
Currently, the interval between sending the measurements is defined
as 60s, but can be configured with the --attestation-interval-seconds
switch.