Skip to content

Conversation

@ansasaki
Copy link
Contributor

Move the EncryptedData and AuthTag structures from common.rs into the keylime library.

This is to continue the effort to move the code that can be shared from the keylime-agent application to the keylime library

Move the AuthTag structure from the common.rs file to the Keylime
library in crypto::auth_tag

Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
@ansasaki ansasaki force-pushed the move_encrypted_data branch from a4e7ff4 to 269210b Compare April 11, 2025 16:09
@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.48%. Comparing base (5bcce7e) to head (e51ae56).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
keylime/src/crypto/encrypted_data.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 63.48% <94.11%> (+0.06%) ⬆️
upstream-unit-tests 63.48% <94.11%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
keylime-agent/src/common.rs 64.42% <ø> (-1.71%) ⬇️
keylime-agent/src/keys_handler.rs 65.71% <ø> (+0.25%) ⬆️
keylime-agent/src/payloads.rs 83.90% <ø> (ø)
keylime/src/crypto.rs 67.23% <ø> (ø)
keylime/src/crypto/auth_tag.rs 100.00% <100.00%> (ø)
keylime/src/crypto/encrypted_data.rs 88.88% <88.88%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sergio-correia sergio-correia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Move the EncryptedData from the common.rs file to the Keylime library in
the keylime::crypto::encrypted_data module.

Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
@ansasaki ansasaki force-pushed the move_encrypted_data branch from 269210b to e51ae56 Compare April 14, 2025 07:35
@ansasaki ansasaki merged commit 17a33ae into keylime:master Apr 14, 2025
11 checks passed
@ansasaki ansasaki deleted the move_encrypted_data branch April 14, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants