-
Notifications
You must be signed in to change notification settings - Fork 71
Move structure filling and URL selection related code to specific modules #999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move structure filling and URL selection related code to specific modules #999
Conversation
ae568b1 to
0bc7cd5
Compare
0bc7cd5 to
f423a1c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Sorry for being picky about the title of the PRs, but again I will suggest you to change it. So, I suggest something like: "Move structure filling and URL selection related code to specific modules". Feel free to rephrase it if it is too long. |
f423a1c to
8a1d676
Compare
My initial idea was decreasing the size of main.rs because it is a "code smell" (to have a high amount of LOC in a main file/method). But yes, I agree your suggestion makes it more descriptive and accurate. Thanks for it!!! |
|
/packit retest-failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This change aims to move structure filling and URL selection related code to specific modules, with a reduce in main.rs lines of code as a consequence Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
8a1d676 to
9efc5bd
Compare
No description provided.