Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(naijatype): supported language description for Naija Type keyboard using the <pre tag results in unresponsive styling #3021

Closed
Meng-Heng opened this issue Jul 17, 2024 · 4 comments · Fixed by #3027
Labels

Comments

@Meng-Heng
Copy link
Contributor

Meng-Heng commented Jul 17, 2024

image
image
I only stumbled one keyboard so far.

@Meng-Heng Meng-Heng added the bug label Jul 18, 2024
@mcdurdin mcdurdin transferred this issue from keymanapp/keyman.com Aug 9, 2024
@mcdurdin mcdurdin changed the title bug: supported language description for Naija Type keyboard using the <pre> tag results in unresponsive styling bug(naijatype): supported language description for Naija Type keyboard using the <pre tag results in unresponsive styling Aug 9, 2024
@mcdurdin
Copy link
Member

mcdurdin commented Aug 9, 2024

https://keyman.com/keyboards/naijatype

This can be addressed by removing the start-of-line whitespace in the <Description> element:

<Description URL="">This keyboard helps you to type any letters used in 100+ Nigerian orthographies including under-dots, underlines, diacritics, tone marks, different shaped letters like a̱ ẹ ɨ ʉ ʊ́ ɓ ɦ m̃ ŋ ₦ and many others all in one keyboard for computers or touch.
Languages covered include: Abua, Adara, Agatu, Agwagwune, Alago, Ashe, Atsam, Awak, Bacama, Bali, Bangwinji, Basa, Bekwarra, Berom, Bokobaru, Bura-Pabir, Burak, Cahungwarya, Cakfem-Mushere, Cishingini, C’Lela, Dadiya, Dghwede, Dikaka, Duya, Dza, Ebira, Edo, Ekajuk, Engenni, English, Etkywan, Etulo, Ezaa, Nigerian Fulfulde, Gbari, Goemai, Gokana, Gude, Gwak, Hausa, Hyam, Ibaas, Ibani, Idoma, Igbo, Igede, Ika, Ikwere, Ikwo, Iten, Ivbie North-Okpela-Arhe, Izere, Izii, Jibu, Jju, Kamuku, Kamwe, Yerwa Kanuri, Karekare, Kibaku, Kirike, Kukele, Kutep, Lamang, Lokaa, Longuda, Mada, Nigeria Mambila, Mbe, Cross River Mbembe, Mbula-Bwazza, Mumuye, Mwaghavul, Ngas, Ninzo, Nupe-Nupe-Tako, Nya Huba, Obolo, Odual, Ogbah, Pangu, Pero, Nigerian Pidgin, Pyam, Reshe, Rigwe, Ron, Tal, Tangale, Tarok, Tera, Tiv, Tsikimba, Tsishingini, Tsuvadi, Tula, Tyap, ut-Hun, ut-Ma’in, Waja, Warji, Yala, Yoruba
This is the package for the keyboard. Lexical models (text completion) for Hausa, English, Ishɛ, Pangu, Fulfulde etc are packaged separately.</Description>

Something like:

    <Description URL="">This keyboard helps you to type any letters used in 100+
Nigerian orthographies including under-dots, underlines, diacritics, tone
marks, different shaped letters like a̱ ẹ ɨ ʉ ʊ́ ɓ ɦ m̃ ŋ ₦ and many others
all in one keyboard for computers or touch.

Languages covered include: Abua, Adara, Agatu, Agwagwune, Alago, Ashe, Atsam,
Awak, Bacama, Bali, Bangwinji, Basa, Bekwarra, Berom, Bokobaru, Bura-Pabir,
Burak, Cahungwarya, Cakfem-Mushere, Cishingini, C’Lela, Dadiya, Dghwede, Dikaka,
Duya, Dza, Ebira, Edo, Ekajuk, Engenni, English, Etkywan, Etulo, Ezaa, Nigerian
Fulfulde, Gbari, Goemai, Gokana, Gude, Gwak, Hausa, Hyam, Ibaas, Ibani, Idoma,
Igbo, Igede, Ika, Ikwere, Ikwo, Iten, Ivbie North-Okpela-Arhe, Izere, Izii,
Jibu, Jju, Kamuku, Kamwe, Yerwa Kanuri, Karekare, Kibaku, Kirike, Kukele, Kutep,
Lamang, Lokaa, Longuda, Mada, Nigeria Mambila, Mbe, Cross River Mbembe,
Mbula-Bwazza, Mumuye, Mwaghavul, Ngas, Ninzo, Nupe-Nupe-Tako, Nya Huba, Obolo,
Odual, Ogbah, Pangu, Pero, Nigerian Pidgin, Pyam, Reshe, Rigwe, Ron, Tal,
Tangale, Tarok, Tera, Tiv, Tsikimba, Tsishingini, Tsuvadi, Tula, Tyap, ut-Hun,
ut-Ma’in, Waja, Warji, Yala, Yoruba

This is the package for the keyboard. Lexical models (text completion) for
Hausa, English, Ishɛ, Pangu, Fulfulde etc are packaged separately.</Description>

@mcdurdin
Copy link
Member

mcdurdin commented Aug 9, 2024

Side note: this might be a good lint rule for the package compiler -- prevent use of indenting for code blocks in Markdown found in the <Description> element?

@Meng-Heng
Copy link
Contributor Author

You know best on this, Marc. Now, should I edit the kps file for this or would your implementation correct the indent for the keyboard?

@mcdurdin
Copy link
Member

Now, should I edit the kps file for this or would your implementation correct the indent for the keyboard?

Yes, go ahead and edit the .kps file. We won't fix this in Keyman Developer until 18.0 release, so best to patch the issue in the .kps first. Don't forget to bump the version number of the keyboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants