Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(web): touch keyboard with empty row causes TypeError: Cannot read property 'length' of undefined #5327

Closed
keyman-sentry bot opened this issue Jun 21, 2021 · 1 comment · Fixed by #5720
Closed

bug(web): touch keyboard with empty row causes TypeError: Cannot read property 'length' of undefined #5327

keyman-sentry bot opened this issue Jun 21, 2021 · 1 comment · Fixed by #5720
Labels
bug developer/compilers/ developer/ web/engine/ web/
Milestone
A15S14

Comments

@keyman-sentry
Copy link

keyman-sentry bot commented Jun 21, 2021

Sentry Issue: KEYMAN-DEVELOPER-8K

TypeError: Cannot read property 'length' of undefined
  at Function.ActiveLayer.polyfill (/resource/keymanweb.js:4733:50)
  at Function.ActiveLayout.polyfill (/resource/keymanweb.js:4973:37)
  at Keyboard.layout (/resource/keymanweb.js:6375:64)
  at OSKManager._Load (/resource/keymanweb.js:29261:62)
  at HTMLScriptElement.<anonymous> (/resource/keymanweb.js:23580:37)
@mcdurdin
Copy link
Member

See https://community.software.sil.org/t/keyboard-compiles-but-web-keyboard-test-for-mobile-hangs-on-install/4981/3 for report.

This issue looks like it is arising in several places. Arguably we should be fixing both KeymanWeb and Keyman Developer -- Developer to clean up the touch keyboard and Web to stop crashing. 😁

afghan_turkmen.zip

@mcdurdin mcdurdin modified the milestones: A15S8, A15S9 Jul 6, 2021
@mcdurdin mcdurdin modified the milestones: A15S9, A15S10 Jul 26, 2021
@mcdurdin mcdurdin modified the milestones: A15S10, A15S11 Aug 8, 2021
@mcdurdin mcdurdin modified the milestones: A15S11, A15S12 Aug 23, 2021
@mcdurdin mcdurdin modified the milestones: A15S12, A15S13 Sep 6, 2021
This was referenced Sep 14, 2021
Closed
Merged
Closed
Merged
@mcdurdin mcdurdin modified the milestones: A15S13, A15S14 Sep 18, 2021
mcdurdin added a commit that referenced this issue Sep 19, 2021
@mcdurdin
fix(developer): remove empty touch rows on save
6de2238 
Fixes #5327.
@mcdurdin mcdurdin mentioned this issue Sep 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug developer/compilers/ developer/ web/engine/ web/
Projects
None yet
Milestone
A15S14
Development

Successfully merging a pull request may close this issue.

fix(developer): remove empty touch rows on save keymanapp/keyman
1 participant
@mcdurdin